perf(optimizer): lower simple integer min/max calls - #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-argument
min()/max()calls currently cross the Zend call boundary even when their operands are exact integers. This optimization lowers eligible calls to scalar comparisons, avoiding argument boxing and runtime dispatch.The fast path accepts native integer variables, integer literals/casts, and resolved non-nullable integer instance properties. Other forms retain the existing runtime path. Casts are evaluated once, and ordinary variable evaluation behavior is preserved.
The included O2 benchmark improves from 482.56 ms to 48.01 ms (10.05x) for 10 million iterations: nine measured pairs, PHP 8.5.10 ZTS, Linux ARM64, PHPX
6a68f38. Reproduction instructions and raw samples are included inbenchmark/min-max.Validation:
PythonModuleTestgenerated-code assertion failures also reproduce with the unmodified baseline optimizer.git diff --checkpassed.